Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#990 - add placeholder to Picker's search input #991

Merged
merged 1 commit into from
Jan 30, 2024
Merged

#990 - add placeholder to Picker's search input #991

merged 1 commit into from
Jan 30, 2024

Conversation

ashbork
Copy link
Contributor

@ashbork ashbork commented Jan 30, 2024

Resolves: #990

Storybook

https://feature-990--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@ashbork ashbork requested a review from a team January 30, 2024 13:07
@ashbork ashbork linked an issue Jan 30, 2024 that may be closed by this pull request
[BUG] Picker placeholder prop isn't applied consistently #990
Closed
1 task
@ashbork ashbork marked this pull request as ready for review January 30, 2024 13:07
@VadymBezpalko VadymBezpalko merged commit 6288eb4 into main Jan 30, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the 990-bug-picker-placeholder-prop-isnt-applied-consistently branch January 30, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Picker placeholder prop isn't applied consistently
2 participants
@ashbork @VadymBezpalko